Messages in this thread | | | Subject | Re: [Linux-fbdev-devel] [PATCH] fbcon: replace mono_col macro with static inline | From | Harvey Harrison <> | Date | Tue, 26 Feb 2008 13:50:02 -0800 |
| |
On Tue, 2008-02-26 at 22:36 +0100, Geert Uytterhoeven wrote: > On Tue, 26 Feb 2008, Harvey Harrison wrote: > > On Tue, 2008-02-26 at 09:18 +0100, Geert Uytterhoeven wrote: > > > On Mon, 25 Feb 2008, Harvey Harrison wrote: > > > > +static inline int mono_col(struct fb_info *info) > > > ^^^^^^^^^^^^^^^^^^^^ > > > const struct fb_info *info? > > > > I suppose, but seeing as it's an inline, does it really matter? > > Sure, if one day a new routine calls mono_col() passing a const struct fb_info > pointer, it won't compile.
Fair enough, want an updated patch, or will Andrew just make the small addition?
Harvey
| |