lkml.org 
[lkml]   [2008]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and &
    From: Julia Lawall <julia@diku.dk>

    In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337, a bug was fixed that
    involved converting !x & y to !(x & y). The code below shows the same
    pattern, and thus should perhaps be fixed in the same way.

    This is not tested and clearly changes the semantics, so it is only
    something to consider.

    The semantic patch that makes this change is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    // <smpl>
    @@ expression E1,E2; @@
    (
    !E1 & !E2
    |
    - !E1 & E2
    + !(E1 & E2)
    )
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---

    diff -u -p a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
    --- a/drivers/net/wireless/iwlwifi/iwl-4965.c 2008-02-05 20:56:01.000000000 +0100
    +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c 2008-02-26 08:09:12.000000000 +0100
    @@ -4589,7 +4589,7 @@ static u8 iwl4965_is_fat_tx_allowed(stru

    if (sta_ht_inf) {
    if ((!sta_ht_inf->ht_supported) ||
    - (!sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH))
    + (!(sta_ht_inf->cap & IEEE80211_HT_CAP_SUP_WIDTH)))
    return 0;
    }


    \
     
     \ /
      Last update: 2008-02-26 21:47    [W:0.026 / U:0.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site