lkml.org 
[lkml]   [2008]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag
    >         return do_mbind(start, len, mode, mode_flags, &nodes, flags);

    The intermingling of 'flags', 'mode' and 'mode_flags' to refer to the
    low bits, the high bits or all the bits of the flags field is handled
    fairly carefully in your patch, but can still be a bit difficult to
    keep track of which is which when reading.

    I'll wager not many readers can immediately say what the 'mode',
    'mode_flags' and 'flags' refer to, in the above code snippet, for
    example.

    Do you have any suggestions on how to further improve the clarity of
    this code?

    --
    I won't rest till it's the best ...
    Programmer, Linux Scalability
    Paul Jackson <pj@sgi.com> 1.940.382.4214


    \
     
     \ /
      Last update: 2008-02-26 18:59    [W:0.021 / U:29.936 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site