Messages in this thread | | | Date | Tue, 26 Feb 2008 09:29:25 -0800 | From | "Yinghai Lu" <> | Subject | Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu |
| |
On Mon, Feb 25, 2008 at 11:33 PM, H. Peter Anvin <hpa@zytor.com> wrote: > Yinghai Lu wrote: > >> which is the same. set_cpu_cap() is indeed the cleaner form to do this > >> so your patch is correct as a cleanup. > > set_cpu_cap is right > > == > > set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); ===> is wrong > > should be > > set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability); > > > > x86_capability is a array ... > > > > For an array, the & is optional and has no effect.
good to know.
YH
| |