Messages in this thread Patch in this message | | | Date | Tue, 26 Feb 2008 12:10:34 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd related? dm-related? |
| |
On Mon, 25 Feb 2008, Jan Kara wrote:
> Yes, exactly two of them. One is non-trivial to get rid of - it's > used for encoding of filename before we write it,
Why can't we do just
UDF: Optimize stack usage
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
diff --git a/fs/udf/namei.c b/fs/udf/namei.c index 112a5fb..706a2b5 100644 --- a/fs/udf/namei.c +++ b/fs/udf/namei.c @@ -336,7 +336,7 @@ static struct fileIdentDesc *udf_add_entry(struct inode *dir, { struct super_block *sb = dir->i_sb; struct fileIdentDesc *fi = NULL; - char name[UDF_NAME_LEN], fname[UDF_NAME_LEN]; + char *name, *fname; int namelen; loff_t f_pos; int flen; @@ -352,6 +352,14 @@ static struct fileIdentDesc *udf_add_entry(struct inode *dir, struct extent_position epos = {}; struct udf_inode_info *dinfo; + name = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL); + fname = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL); + + if (!name || !fname) { + *err = -ENOMEM; + return NULL; + } + if (dentry) { if (!dentry->d_name.len) { *err = -EINVAL; diff --git a/fs/udf/super.c b/fs/udf/super.c index f3ac4ab..42e3ba8 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -1345,7 +1345,7 @@ static void udf_load_logicalvolint(struct super_block *sb, kernel_extent_ad loc) * July 1, 1997 - Andrew E. Mileski * Written, tested, and released. */ -static int udf_process_sequence(struct super_block *sb, long block, +static int noinline udf_process_sequence(struct super_block *sb, long block, long lastblock, kernel_lb_addr *fileset) { struct buffer_head *bh = NULL;
| |