lkml.org 
[lkml]   [2008]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] mmiotrace full patch, preview 1
On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote:
> the things which it finds.
>
> > +static DECLARE_MUTEX(kmmio_init_mutex);
>
> That's not a mutex.
>
> > + down(&kmmio_init_mutex);
>
> It's a semaphore. Please do convert it to a mutex.
>
> Andy, I'd say that addition of new semaphores is worth a warning - they're
> rarely legitimate.

I'm not sure that any semaphore should be a warning, but the initializer
for semaphore used as binary mutex (DECLARE_MUTEX and init_MUTEX) are
worth it.



\
 
 \ /
  Last update: 2008-02-26 00:37    [from the cache]
©2003-2011 Jasper Spaans