Messages in this thread | | | Date | Tue, 26 Feb 2008 01:26:17 +0300 | From | Evgeniy Polyakov <> | Subject | Re: [PATCH 1/2] [W1] ds1wm: should check for IS_ERR(clk) instead of NULL |
| |
Hi Anton.
On Tue, Feb 26, 2008 at 12:24:26AM +0300, Anton Vorontsov (cbouatmailru@gmail.com) wrote: > On the error condition clk_get() returns ERR_PTR(..), so checking > for NULL doesn't work. ds1wm module causes a kernel oops when ds1wm > clock isn't registered. > > This patch converts NULL check to IS_ERR(), plus uses PTR_ERR() > for the return code. > > Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
Both patches look good, thanks Anton.
Andrew, please merge them and add my ack if needed. Thank you.
-- Evgeniy Polyakov
| |