lkml.org 
[lkml]   [2008]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [(RT RFC) PATCH v2 3/9] rearrange rt_spin_lock sleep
Hi!

> @@ -720,7 +728,8 @@ rt_spin_lock_slowlock(struct rt_mutex *lock)
> * saved_state accordingly. If we did not get a real wakeup
> * then we return with the saved state.
> */
> - saved_state = xchg(&current->state, TASK_UNINTERRUPTIBLE);
> + saved_state = current->state;
> + smp_mb();
>
> for (;;) {
> unsigned long saved_flags;

Please document what the barrier is good for.

Plus, you are replacing atomic operation with nonatomic; is that ok?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2008-02-25 22:57    [from the cache]
©2003-2011 Jasper Spaans