lkml.org 
[lkml]   [2008]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Change a WARN message in checkpatch
On Sun, Feb 24, 2008 at 07:14:13PM +0100, Paolo Ciarrocchi wrote:
> On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <bhalevy@panasas.com> wrote:
> [...]
> > How about:
> > - WARN("no space between function name and open parenthesis '('\n" . $herecurr);
> > + WARN("there should be no space between function name and open parenthesis '('\n" . $herecurr);
>
> I originally suggested:
> + WARN("don't put a space between
> function name and open parenthesis '('\n" . $herecurr);
> but I really prefer your version.
>
> > The original phrasing can be interpreted like "there is no space between ..." and the correct
> > interpretation should be "there should be no space between ..."
>
> Indeed.

As we want the messages to be as short as possible, I am leaning towards
standardising on:

spaces prohibited <where>
spaces required <where>

-apw


\
 
 \ /
  Last update: 2008-02-25 04:31    [from the cache]
©2003-2011 Jasper Spaans