lkml.org 
[lkml]   [2008]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: Linux 2.6.25-rc3
    Date
    Hi;

    25 Şub 2008 Pts tarihinde, Linus Torvalds şunları yazmıştı:
    >
    > Ok, it's out there, ready for your enjoyment.
    [...]
    > So give it a good testing, please,

    -rc3 still fails for this [1] config

    ERROR: "LGUEST_PAGES_guest_gdt_desc" [drivers/lguest/lg.ko] undefined!
    ERROR: "LGUEST_PAGES_host_gdt_desc" [drivers/lguest/lg.ko] undefined!
    ERROR: "LGUEST_PAGES_host_cr3" [drivers/lguest/lg.ko] undefined!
    ERROR: "LGUEST_PAGES_regs" [drivers/lguest/lg.ko] undefined!
    ERROR: "LGUEST_PAGES_host_idt_desc" [drivers/lguest/lg.ko] undefined!
    ERROR: "LGUEST_PAGES_guest_gdt" [drivers/lguest/lg.ko] undefined!
    ERROR: "LGUEST_PAGES_host_sp" [drivers/lguest/lg.ko] undefined!
    ERROR: "LGUEST_PAGES_regs_trapnum" [drivers/lguest/lg.ko] undefined!
    ERROR: "LGUEST_PAGES_guest_idt_desc" [drivers/lguest/lg.ko] undefined!

    and following patch by Kyle McMartin solves this issue, this patch posted on 20 Feb to LKML but not CC'd to you.

    From: Kyle McMartin <kyle@mcmartin.ca>

    lguest uses asm-offsets to generate ... offsets, obviously, for use
    in the lguest switcher code. When the hypervisor code is built as a
    module though, the asm offsets it needs won't be generated since
    CONFIG_LGUEST will be undefined.

    Signed-off-by: Kyle McMartin <kmcmartin@redhat.com>

    ---
    diff --git a/arch/x86/kernel/asm-offsets_32.c b/arch/x86/kernel/asm-offsets_32.c
    index a33d530..44bafdd 100644
    --- a/arch/x86/kernel/asm-offsets_32.c
    +++ b/arch/x86/kernel/asm-offsets_32.c
    @@ -134,7 +134,7 @@ void foo(void)
            OFFSET(LGUEST_DATA_pgdir, lguest_data, pgdir);
     #endif
     
    -#ifdef CONFIG_LGUEST
    +#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_MODULE)
            BLANK();
            OFFSET(LGUEST_PAGES_host_gdt_desc, lguest_pages, state.host_gdt_desc);
            OFFSET(LGUEST_PAGES_host_idt_desc, lguest_pages, state.host_idt_desc);


    [1] http://cekirdek.pardus.org.tr/~caglar/config.2.6.25-rc3
    Cheers
    --
    S.Çağlar Onur <caglar@pardus.org.tr>
    http://cekirdek.pardus.org.tr/~caglar/

    Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2008-02-25 00:35    [W:0.048 / U:32.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site