lkml.org 
[lkml]   [2008]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 8/8] Jhash in too big for inlining, move under lib/
    On Sat, 23 Feb 2008 12:05:36 +0200 (EET) "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi> wrote:

    > On Sat, 23 Feb 2008, Andrew Morton wrote:
    >
    > > On Wed, 20 Feb 2008 15:47:18 +0200 "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi> wrote:
    > >
    > > > vmlinux.o:
    > > > 62 functions changed, 66 bytes added, 10935 bytes removed, diff: -10869
    > > >
    > > > ...+ these to lib/jhash.o:
    > > > jhash_3words: 112
    > > > jhash2: 276
    > > > jhash: 475
    > > >
    > > > select for networking code might need a more fine-grained approach.
    > >
    > > It should be possible to use a modular jhash.ko. The things which you
    > > have identified as clients of the jhash library are usually loaded as modules.
    > > But in the case where someone does (say) NFSD=y we do need jhash.o linked into
    > > vmlinux also. This is doable in Kconfig but I always forget how.
    >
    > Ok, even though its not that likely that one lives without e.g.
    > net/ipv4/inet_connection_sock.c or net/netlink/af_netlink.c?

    Sure, the number of people who will want CONFIG_JHASH=n is very small.

    > But maybe
    > some guys "really know what they are doing" and can come up with config
    > that would be able to build it as module (for other than proof-of-concept
    > uses I mean)... :-/
    >
    > > Adrian, Sam and Randy are the repositories of knowledge here ;)
    >
    > Thanks, I'll consult them in this. I've never needed to do any Kconfig
    > stuff so far so it's no surprise I have very little clue... :-)

    Thanks. If it gets messy I'd just put lib/jhash.o in obj-y. I assume it's
    pretty small.

    > I've one question for you Andrew, how would you like this kind of
    > cross-subsys toucher to be merged, through you directly I suppose?

    Sure, I can scrounge around for appropriate reviews and acks and can make
    sure that nobody's pending work gets disrupted.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-02-23 19:25    [W:0.029 / U:89.656 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site