[lkml]   [2008]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/2] ResCounter: Use read_uint in memory controller
    On Thu, Feb 21, 2008 at 8:29 PM, Balbir Singh <> wrote:
    > Looks good, except for the name uint(), can we make it u64(). Integers are 32
    > bit on both ILP32 and LP64, but we really read/write 64 bit values.

    Yes, that's true. But read_uint() is more consistent with all the
    other instances in cgroups and subsystems. So if we were to call it
    res_counter_read_u64() I'd also want to rename all the other
    *read_uint functions/fields to *read_u64 too. Can I do that in a
    separate patch?


     \ /
      Last update: 2008-02-23 15:37    [W:0.021 / U:0.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site