lkml.org 
[lkml]   [2008]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subject[PATCH 0/2] firewire: endinaness warnings (was Re: sparse - make __CHECK_ENDIAN__ default enabled?)
    On 20 Feb, Harvey Harrison wrote on LKML:
    > On Wed, 2008-02-20 at 23:03 +0100, Sam Ravnborg wrote:
    >> Hi Harvey.
    >>
    >> Can I ask you to look into the worst offenders so we
    >> can make -D__CHECK_ENDIAN__ enabled per default
    >> in the kernel.
    >> Or maybe we should do it anyway?
    >
    > Well, I've got the worst of fs and drivers/ata done so far, still
    > weeping over the 5500 warnings in drivers. (X86_32 allyesconfig).
    > People ignore the existing warnings anyway, why not toss a few more
    > on the pile?
    >
    > I'll look them over tonight and see how bad it would be.

    I looked into drivers/firewire and drivers/ieee1394. As expected, there
    are quite a lot endianess related warnings in the latter because this is
    code from way before sparse was regularly used.

    There are also a few warnings in the former, even though sparse checks
    were run before submission of the whole drivers/firewire stack. I will
    follow up with two patches:
    1/2 firewire: endianess fix
    2/2 firewire: endianess annotations
    Whether the "fix" is really a fix remains to be seen; I don't have a big
    endian Linux box myself.
    --
    Stefan Richter
    -=====-==--- --=- =-===
    http://arcgraph.de/sr/



    \
     
     \ /
      Last update: 2008-02-23 12:27    [W:0.021 / U:0.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site