Messages in this thread | | | From | David Brownell <> | Subject | Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86 | Date | Fri, 22 Feb 2008 16:51:30 -0800 |
| |
On Friday 22 February 2008, Anton Vorontsov wrote: > > +static inline int gpio_request(unsigned gpio, const char *label) > > +{ > > + return -EINVAL; > > Could we return -ENOSYS instead, so drivers will able to distinguish > between "something really failed" and "there is no gpio support, > fallback to other methods"? Without this, the notorious NAND driver > will hardly benefit from this change. ;-)
Sure; that'll be gpio_request() and the gpio_direction_*() calls only though, since those are the initial setup calls drivers make.
- Dave
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |