lkml.org 
[lkml]   [2008]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 10/38] TCP: Fix a bug in strategy_allowed_congestion_control
    2.6.24-stable review patch.  If anyone has any objections, please let us
    know.

    ------------------

    Upstream commit: 16ca3f913001efdb6171a2781ef41c77474e3895

    In strategy_allowed_congestion_control of the 2.6.24 kernel, when
    sysctl_string return 1 on success,it should call
    tcp_set_allowed_congestion_control to set the allowed congestion
    control.But, it don't. the sysctl_string return 1 on success,
    otherwise return negative, never return 0.The patch fix the problem.

    Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
    Acked-by: Stephen Hemminger <shemminger@vyatta.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/ipv4/sysctl_net_ipv4.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ipv4/sysctl_net_ipv4.c
    +++ b/net/ipv4/sysctl_net_ipv4.c
    @@ -248,7 +248,7 @@ static int strategy_allowed_congestion_c

    tcp_get_available_congestion_control(tbl.data, tbl.maxlen);
    ret = sysctl_string(&tbl, name, nlen, oldval, oldlenp, newval, newlen);
    - if (ret == 0 && newval && newlen)
    + if (ret == 1 && newval && newlen)
    ret = tcp_set_allowed_congestion_control(tbl.data);
    kfree(tbl.data);

    --


    \
     
     \ /
      Last update: 2008-02-23 01:41    [W:0.021 / U:0.348 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site