lkml.org 
[lkml]   [2008]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 12/20] x86: Coding Style fixes to arch/x86/kernel/cpu/mcheck/non-fatal.c
    File is now error and warning free.
    Compile tested.


    Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
    ---
    arch/x86/kernel/cpu/mcheck/non-fatal.c | 21 ++++++++++++---------
    1 files changed, 12 insertions(+), 9 deletions(-)

    diff --git a/arch/x86/kernel/cpu/mcheck/non-fatal.c b/arch/x86/kernel/cpu/mcheck/non-fatal.c
    index bf39409..00ccb6c 100644
    --- a/arch/x86/kernel/cpu/mcheck/non-fatal.c
    +++ b/arch/x86/kernel/cpu/mcheck/non-fatal.c
    @@ -16,7 +16,7 @@
    #include <linux/smp.h>
    #include <linux/module.h>

    -#include <asm/processor.h>
    +#include <asm/processor.h>
    #include <asm/system.h>
    #include <asm/msr.h>

    @@ -26,23 +26,26 @@ static int firstbank;

    #define MCE_RATE 15*HZ /* timer rate is 15s */

    -static void mce_checkregs (void *info)
    +static void mce_checkregs(void *info)
    {
    u32 low, high;
    int i;

    - for (i=firstbank; i<nr_mce_banks; i++) {
    - rdmsr (MSR_IA32_MC0_STATUS+i*4, low, high);
    + for (i = firstbank; i < nr_mce_banks; i++) {
    + rdmsr(MSR_IA32_MC0_STATUS+i*4, low, high);

    if (high & (1<<31)) {
    printk(KERN_INFO "MCE: The hardware reports a non "
    "fatal, correctable incident occurred on "
    "CPU %d.\n",
    smp_processor_id());
    - printk (KERN_INFO "Bank %d: %08x%08x\n", i, high, low);
    + printk(KERN_INFO "Bank %d: %08x%08x\n", i, high, low);

    - /* Scrub the error so we don't pick it up in MCE_RATE seconds time. */
    - wrmsr (MSR_IA32_MC0_STATUS+i*4, 0UL, 0UL);
    + /*
    + * Scrub the error so we don't pick it up in MCE_RATE
    + * seconds time.
    + */
    + wrmsr(MSR_IA32_MC0_STATUS+i*4, 0UL, 0UL);

    /* Serialize */
    wmb();
    @@ -55,10 +58,10 @@ static void mce_work_fn(struct work_struct *work);
    static DECLARE_DELAYED_WORK(mce_work, mce_work_fn);

    static void mce_work_fn(struct work_struct *work)
    -{
    +{
    on_each_cpu(mce_checkregs, NULL, 1, 1);
    schedule_delayed_work(&mce_work, round_jiffies_relative(MCE_RATE));
    -}
    +}

    static int __init init_nonfatal_mce_checker(void)
    {
    --
    1.5.4.GIT


    \
     
     \ /
      Last update: 2008-02-22 23:21    [W:0.026 / U:61.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site