lkml.org 
[lkml]   [2008]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 14/23] via-velocity: dont oops on MTU change (resend)

    2.6.22-stable review patch. If anyone has any objections, please let us
    know.

    ------------------

    From: Stephen Hemminger <shemminger@linux-foundation.org>

    mainline: 48f6b053613b62fed7a2fe3255e5568260a8d615

    The VIA veloicty driver needs the following to allow changing MTU when down.
    The buffer size needs to be computed when device is brought up, not when
    device is initialized. This also fixes a bug where the buffer size was
    computed differently on change_mtu versus initial setting.

    Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
    Signed-off-by: Jeff Garzik <jeff@garzik.org>
    Acked-by: Jeff Mahoney <jeffm@suse.com>
    CC: Oliver Pinter <oliver.pntr@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/via-velocity.c | 11 +++--------
    1 file changed, 3 insertions(+), 8 deletions(-)

    --- a/drivers/net/via-velocity.c
    +++ b/drivers/net/via-velocity.c
    @@ -1075,6 +1075,9 @@ static int velocity_init_rd_ring(struct
    int ret = -ENOMEM;
    unsigned int rsize = sizeof(struct velocity_rd_info) *
    vptr->options.numrx;
    + int mtu = vptr->dev->mtu;
    +
    + vptr->rx_buf_sz = (mtu <= ETH_DATA_LEN) ? PKT_BUF_SZ : mtu + 32;

    vptr->rd_info = kmalloc(rsize, GFP_KERNEL);
    if(vptr->rd_info == NULL)
    @@ -1733,8 +1736,6 @@ static int velocity_open(struct net_devi
    struct velocity_info *vptr = netdev_priv(dev);
    int ret;

    - vptr->rx_buf_sz = (dev->mtu <= 1504 ? PKT_BUF_SZ : dev->mtu + 32);
    -
    ret = velocity_init_rings(vptr);
    if (ret < 0)
    goto out;
    @@ -1813,12 +1814,6 @@ static int velocity_change_mtu(struct ne
    velocity_free_rd_ring(vptr);

    dev->mtu = new_mtu;
    - if (new_mtu > 8192)
    - vptr->rx_buf_sz = 9 * 1024;
    - else if (new_mtu > 4096)
    - vptr->rx_buf_sz = 8192;
    - else
    - vptr->rx_buf_sz = 4 * 1024;

    ret = velocity_init_rd_ring(vptr);
    if (ret < 0)
    --


    \
     
     \ /
      Last update: 2008-02-22 22:53    [W:0.021 / U:30.852 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site