Messages in this thread | | | Date | Fri, 22 Feb 2008 20:11:09 +0100 | From | "Bart Van Assche" <> | Subject | Re: [ofa-general] Re: Merging of completely unreviewed drivers |
| |
On Fri, Feb 22, 2008 at 7:54 PM, Ingo Molnar <mingo@elte.hu> wrote: > If a patch or if a file has a clean _style_, bugs and deeper > structural problems often stand out like a sore thumb. But if the > code is peppered with random style noise, it's a lot harder (for me > at least) to notice real bugs. I can notice bugs in a squeeky clean > code base about 5 times easier than in a noisy codebase. This effect > alone makes checkpatch indispensible for the scheduler and for > arch/x86.
I also appreciate style uniformity in kernel code. My (limited) experience with checkpatch is that most checkpatch complaints are easy to resolve.
Bart Van Assche.
| |