Messages in this thread | | | Date | Fri, 22 Feb 2008 09:04:59 -0800 | From | Greg KH <> | Subject | Re: [PATCH 1/3] exporting capability name/code pairs (final) |
| |
On Fri, Feb 22, 2008 at 10:49:26AM +0900, Kohei KaiGai wrote: > [1/3] Add a private data field within kobj_attribute structure.
Your "Subject" did not line up with this description, please change your patch sending format for the next time.
> This patch add a private data field, declared as void *, within kobj_attribute > structure. The _show() and _store() method in the sysfs attribute entries can > refer this information to identify what entry is accessed. > It makes easier to share a single method implementation with several similar > entries, like ones to export the list of capabilities the running kernel > supported. > > Signed-off-by: KaiGai Kohei <kaigai@ak.jp.nec.com>
This looks fine, but I'll not take it unless the documentation is updated, as well as the sample code.
thanks,
greg k-h
| |