Messages in this thread | | | Date | Fri, 22 Feb 2008 09:59:41 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH 2/2] ResCounter: Use read_uint in memory controller |
| |
menage@google.com wrote: > Update the memory controller to use read_uint for its > limit/usage/failcnt control files, calling the new > res_counter_read_uint() function. > > Signed-off-by: Paul Menage <menage@google.com> >
Hi, Paul,
Looks good, except for the name uint(), can we make it u64(). Integers are 32 bit on both ILP32 and LP64, but we really read/write 64 bit values.
-- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL
| |