lkml.org 
[lkml]   [2008]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] mac80211: check endianness/types in sparse runs
    From
    Date
    >> [patch doing CHECKFLAGS += -D__CHECK_ENDIAN__ in the
    >> net/mac80211/Makefile]

    > I would prefer it to be kernel wide enabled.
    > Tried a defconfig build.

    Hm. I tend to think there was a reason for this, since this is actually
    explicitly disabled by include/linux/types.h:

    #ifdef __CHECKER__
    #define __bitwise__ __attribute__((bitwise))
    #else
    #define __bitwise__
    #endif

    #ifdef __CHECK_ENDIAN__
    #define __bitwise __bitwise__
    #else
    #define __bitwise
    #endif

    The commit that introduced __CHECK_ENDIAN__ was
    af4ca457eaf2d6682059c18463eb106e2ce58198 ("gfp_t: infrastructure") but
    it doesn't say anything about the rationale for it.

    > When I enabled __CHECK_ENDIAN I got:
    > 8 files with > 100 warnings
    > 14 files with 10 to 99 warnings.
    >
    > So nothing that should scare a kernel hacker...
    >
    > warnings without: 1686
    > warnings with: 2788
    >
    > OK - thats a lot, but then fixing 8 files will significantly
    > reduce this.

    I recently ran sparse on my config and was surprised by the number of
    warnings. Then again, something in mmzone.h or so generated billions of
    them...

    In any case, I would love to have __CHECK_ENDIAN__ enabled by default at
    least on the wireless code (just caught another bug with it...)

    johannes
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2008-02-21 20:23    [W:4.360 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site