Messages in this thread Patch in this message | | | Date | Wed, 20 Feb 2008 00:36:54 -0800 | From | Yinghai Lu <> | Subject | [PATCH 2/4] x86_64: fix dma_alloc_pages v2 |
| |
one system with two nodes and two ht links on every node. the bios already have _pxm for two links.
when no ram installed for node1 will have panic.
reason: the device on second chain will get node = 1 from dev_to_node...via pci_acpi_scan_root. but node1 doesn't have ram installed. in dma_alloc_pages it will pass check with first_node(node_online_map)... and will have problem with __alloc_pages in alloc_pages_node.
this patch will use updated dev_to node, so remove check about fist_node etc
Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Index: linux-2.6/arch/x86/kernel/pci-dma_64.c =================================================================== --- linux-2.6.orig/arch/x86/kernel/pci-dma_64.c +++ linux-2.6/arch/x86/kernel/pci-dma_64.c @@ -53,12 +53,6 @@ dma_alloc_pages(struct device *dev, gfp_ int node; node = dev_to_node(dev); - if (node == -1) - node = numa_node_id(); - - if (node < first_node(node_online_map)) - node = first_node(node_online_map); - page = alloc_pages_node(node, gfp, order); return page ? page_address(page) : NULL; }
| |