Messages in this thread | | | Date | Thu, 21 Feb 2008 14:58:29 +1100 | From | Paul Mackerras <> | Subject | Re: [PATCH] viocons: BKL locking |
| |
Alan Cox writes:
> For some weird reason I can't ascertain (translation "I think its > broken") the viocons driver calls directly into the n_tty ldisc code even > if another ldisc is in use. It'll probably break if you do that but I'm > just fixing the locking and adding a comment that its horked.
Looks to me like it (viotty_ioctl) should return -ENOIOCTLCMD instead of calling n_tty_ioctl -- do you agree?
Paul.
| |