lkml.org 
[lkml]   [2008]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: mm/slub.c: inconsequent NULL checking
From
Date

Hi Adrian,

On 2/20/2008, "Adrian Bunk" <bunk@kernel.org> wrote:
> The Coverity checker spotted the following inconsequent NULL checking
> introduced by commit 8ff12cfc009a2a38d87fa7058226fe197bb2696f:
>
> <-- snip -->
>
> ...
> static inline int is_end(void *addr)
> {
> return (unsigned long)addr & PAGE_MAPPING_ANON;
> }
> ...
> static void deactivate_slab(struct kmem_cache *s, struct kmem_cache_cpu *c)
> {
> ...
> if (c->freelist) <----------------------------------------
> stat(c, DEACTIVATE_REMOTE_FREES);

I spotted this too. c->freelist should never be NULL so why not send a
patch to Christoph?


\
 
 \ /
  Last update: 2008-02-20 14:55    [from the cache]
©2003-2011 Jasper Spaans