Messages in this thread | | | Date | Sun, 03 Feb 2008 09:57:11 +0800 | From | Li Zefan <> | Subject | Re: linux-2.6.24 compile error in drivers/net/b44.c |
| |
Li Zefan wrote: > Miguel Botón 写道: >> Li Zefan wrote: >>> Add CCs: >>> >>> CC: mboton@gmail.com >>> CC: zambrano@broadcom.com >>> CC: linville@tuxdriver.com >>> >>> Li Zefan wrote: >>>> drivers/net/b44.c: In function 'b44_remove_one': >>>> drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' >>>> make[2]: *** [drivers/net/b44.o] Error 1 >>>> make[1]: *** [drivers/net] Error 2 >>>> >>>> I think it is caused by: >>>> >>>> CONFIG_SSB_PCIHOST=n >>>> CONFIG_B44=y >>>> >> This patch should fix b44 errors when 'SSB_PCIHOST' is not enabled. >> > > I tried the patch, but it does't work, same compile error. :( > > If .config is needed, tell me and I will attach it. >
Sorry, I just made a mistake, actually the patch works.
Thanks!
>> Signed-off-by: Miguel Botón <mboton@gmail.com> >> >> diff --git a/drivers/net/b44.c b/drivers/net/b44.c >> index ea2a2b5..d081234 100644 >> --- a/drivers/net/b44.c >> +++ b/drivers/net/b44.c >> @@ -2228,7 +2228,9 @@ static void __devexit b44_remove_one(struct ssb_device *sdev) >> unregister_netdev(dev); >> ssb_bus_may_powerdown(sdev->bus); >> free_netdev(dev); >> +#ifdef B44_PCI >> ssb_pcihost_set_power_state(sdev, PCI_D3hot); >> +#endif >> ssb_set_drvdata(sdev, NULL); >> } >> >> @@ -2257,7 +2259,9 @@ static int b44_suspend(struct ssb_device *sdev, pm_message_t state) >> b44_setup_wol(bp); >> } >> >> +#ifdef B44_PCI >> ssb_pcihost_set_power_state(sdev, PCI_D3hot); >> +#endif >> return 0; >> } >> >> -- >> Miguel Botón >> >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |