Messages in this thread | | | Date | Sat, 02 Feb 2008 16:14:26 +0800 | From | Li Zefan <> | Subject | Re: [PATCH 2/3] x86: add function prototype to vm86.h |
| |
Harvey Harrison 写道: > Global functions should include their prototypes. > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> > --- > include/asm-x86/vm86.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/asm-x86/vm86.h b/include/asm-x86/vm86.h > index a5edf51..b72b9a6 100644 > --- a/include/asm-x86/vm86.h > +++ b/include/asm-x86/vm86.h > @@ -195,6 +195,7 @@ struct kernel_vm86_struct { > > void handle_vm86_fault(struct kernel_vm86_regs *, long); > int handle_vm86_trap(struct kernel_vm86_regs *, long, int); > +struct pt_regs * save_v86_state(struct kernel_vm86_regs *); >
This fixes a sparse warning, but contribute to a coding style error. checkpatch.pl complains about this patch.
so the above line should be: struct pt_regs *save_v86_state(struct kernel_vm86_regs *);
> struct task_struct; > void release_vm86_irqs(struct task_struct *);
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |