Messages in this thread | | | Date | Sat, 2 Feb 2008 09:39:08 -0600 | From | Olof Johansson <> | Subject | Re: [PATCH] Fix fallout from PCI: PCIE ASPM support |
| |
On Fri, Feb 01, 2008 at 09:59:21PM -0800, H. Peter Anvin wrote: > Olof Johansson wrote: >> On Sat, Feb 02, 2008 at 05:06:42AM +0000, Linux Kernel Mailing List wrote: >> >>> PCI: PCIE ASPM support >> >> This one broke almost all defconfigs on powerpc, since they enable >> CONFIG_EXPERIMENTAL and CONFIG_PCI, and this option defaults to y. >> >> Make it default to 'n' like most other options, and make it depend on >> ACPI. Take out the unneccessary default 'n' from the debug option as well. >> > > Is this actually ACPI-dependent?
It shouldn't be, but it seems like it's currently entangled a bit with the acpi include files. OSC_ACTIVE_STATE_PWR_SUPPORT comes from linux/pci-acpi.h.
I can't include acpi/acpi_bus.h though, since that ends up pulling in asm/ files that don't exist on powerpc.
So if the probing is fixed, no, it's not ACPI-dependent. Seems like something that's just as well to mask behind it until someone's actually used and tested it on a non-ACPI platform though, no?
I would experiment with it but I believe our firmware turns off empty links before the kernel is booted, we don't support hotplug at this time.
-Olof
| |