lkml.org 
[lkml]   [2008]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check
Roland McGrath wrote::
> This change looks bogus to me. Before I get to the content, there is a nit
> that annoys me. You changed the punctuation in my comment so that it no
> longer means what it did, and now the comment is nonsensical. I don't
> demand decent English from hackers of any linguistic bent, but please don't
> louse up the coherent sentences I wrote when moving them down ten lines.
>
> Please elaborate on the rationale that justifies this change.
> I don't see it at all.

I have corrected the comment in the latest patch which has been apllied by Ingo.
Please refer to http://lkml.org/lkml/2008/2/18/575 and http://lkml.org/lkml/2008/2/19/119 .

Thanks.
Shi Weihua

>
> If you are already on the signal stack, it doesn't matter whether the
> signal that just arrived has SA_ONSTACK set or not. If you are going to
> overflow the stack with the new signal frame, we want to prevent that
> clobberation regardless.
>
>
> Thanks,
> Roland
>
>
>



\
 
 \ /
  Last update: 2008-02-20 01:53    [W:0.058 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site