lkml.org 
[lkml]   [2008]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/8] net: use numa_node in net_devcice->dev instead of parent
On Tuesday 19 February 2008 03:41:10 am David Miller wrote:
> From: Ingo Molnar <mingo@elte.hu>
> Date: Tue, 19 Feb 2008 12:21:46 +0100
>
> >
> > * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> >
> > > struct sk_buff *__netdev_alloc_skb(struct net_device *dev,
> > > unsigned int length, gfp_t gfp_mask)
> > > {
> > > - int node = dev->dev.parent ? dev_to_node(dev->dev.parent) : -1;
> > > + int node = dev_to_node(&dev->dev);
> >
> > i think this is a fix for the networking folks. (Dave Cc:-ed)
>
> It keeps getting NAK's because it's wrong.
>
> The author of the patch hasn't convinced folks why this is really
> necessary, and using the net_device embedded device struct is
> definitely wrong here. It doesn't contain the NUMA node information,
> the physical device does, and that is what the parent it.

can you check the 5/8?
that will make sure every struct device get numa_node get assigned.

YH


\
 
 \ /
  Last update: 2008-02-19 20:25    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog