Messages in this thread | | | Date | Mon, 18 Feb 2008 16:16:04 -0600 | From | David Teigland <> | Subject | Re: [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization |
| |
On Mon, Feb 18, 2008 at 11:30:30AM -0800, Mark Fasheh wrote: > On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote: > > default_groups was allocated with kcalloc, so initialize to NULL > > is unnecessary. > > NACK - this isn't a performance critical section of code and that line makes > the array termination obvious, so I'm inclined to leave it as is.
The same nack for the same patch under fs/dlm.
Dave
| |