Messages in this thread | | | Date | Mon, 18 Feb 2008 15:05:46 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] Fix left over EFI cache mapping problems |
| |
* Andi Kleen <andi@firstfloor.org> wrote:
> > UEFI specification 2.1 (section 6.2, page 124) that the > > NumberOfPages (num_pages) of EFI_MEMORY_DESCRIPTOR > > (efi_memory_desc_t) must be "Number of 4KB pages in the memory > > region". So we need not worry about potential EFI_PAGE_SHIFT > > changes. > > Then it would be cleaner to just use PAGE_SIZE in the x86 specific EFI > code imho.
(as i suggested in the mail Ying replied to.)
But ... as long as ia64 uses EFI too i dont mind if it's using EFI_PAGE_SHIFT consistently, even in the arch/x86-only files.
Ingo
| |