lkml.org 
[lkml]   [2008]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6 patch] fs/drop_caches.c: make 2 functions static
    On Sun, 17 Feb 2008 10:17:46 +0200 Adrian Bunk <bunk@kernel.org> wrote:

    > This patch makes the following needlessly global functions static:
    > - drop_pagecache()
    > - drop_slab()
    >
    > Signed-off-by: Adrian Bunk <bunk@kernel.org>
    >
    > ---
    >
    > fs/drop_caches.c | 4 ++--
    > include/linux/mm.h | 2 --
    > 2 files changed, 2 insertions(+), 4 deletions(-)
    >
    > 32191754eb7aed31406850a082565bc428268a08 diff --git a/fs/drop_caches.c b/fs/drop_caches.c
    > index 59375ef..e2c6b65 100644
    > --- a/fs/drop_caches.c
    > +++ b/fs/drop_caches.c
    > @@ -25,7 +25,7 @@ static void drop_pagecache_sb(struct super_block *sb)
    > spin_unlock(&inode_lock);
    > }
    >
    > -void drop_pagecache(void)
    > +static void drop_pagecache(void)
    > {
    > struct super_block *sb;
    >
    > @@ -45,7 +45,7 @@ restart:
    > spin_unlock(&sb_lock);
    > }
    >
    > -void drop_slab(void)
    > +static void drop_slab(void)
    > {
    > int nr_objects;
    >

    This was originally done because Neil said that he planned to use these in
    nfsd. I guess that didn't happen, and an additional patch would be needed
    here anyway to do the module exports. So.... zap.


    \
     
     \ /
      Last update: 2008-02-18 14:07    [W:0.026 / U:1.596 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site