| Date | Sat, 16 Feb 2008 22:25:40 -0800 | From | Joel Becker <> | Subject | Re: 2.6.25-rc2-mm1 |
| |
On Sat, Feb 16, 2008 at 12:25:22AM -0800, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc2/2.6.25-rc2-mm1/ ... > +avoid-divides-in-bits_to_longs.patch
Andrew, This patch, by introducing sizeof(long) in the BITS_TO_LONGS math, changes BITS_TO_LONGS from an int to a unsigned long. We noticed because this printk in fs/ocfs2/dlm/dlmdomain.c:
mlog(ML_ERROR, "map_size %u != BITS_TO_LONGS(O2NM_MAX_NODES) %u\n", map_size, BITS_TO_LONGS(O2NM_MAX_NODES));
now gives this warning:
fs/ocfs2/dlm/dlmdomain.c:938: warning: format '%u' expects type 'unsigned int', but argument 7 has type 'long unsigned int'
We can tweak the printk once the patch goes to Linus, no worries. I just wanted to send a heads up in case the size change affects anything else.
Joel
--
There are morethings in heaven and earth, Horatio, Than are dreamt of in your philosophy.
Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127
|