lkml.org 
[lkml]   [2008]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix left over EFI cache mapping problems
Huang, Ying wrote:
> On Fri, 2008-02-15 at 09:48 +0100, Andi Kleen wrote:
>> On Fri, Feb 15, 2008 at 12:48:06PM +0800, Huang, Ying wrote:
>>> This patch has been tested on Intel x86 platform with EFI 32/64.
>> Can EFI_PAGE_SIZE ever be < 4k? If yes you would need to round up
>> first to linux page size before shifting.
>
> Yes. It is needed. And md->virt_addr should be processed as follow:
>
> md->virt_addr & PAGE_MASK
>
> before fed into set_memory_*.

If you do that you also need to add the old offset into the page
to the size.

I just mention it because ioremap_change_attr() did that wrong
before my patch yesterday :)

-Andi



\
 
 \ /
  Last update: 2008-02-15 10:45    [W:0.044 / U:1.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site