Messages in this thread | | | Date | Fri, 15 Feb 2008 10:43:08 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH] Fix left over EFI cache mapping problems |
| |
Huang, Ying wrote: > On Fri, 2008-02-15 at 09:48 +0100, Andi Kleen wrote: >> On Fri, Feb 15, 2008 at 12:48:06PM +0800, Huang, Ying wrote: >>> This patch has been tested on Intel x86 platform with EFI 32/64. >> Can EFI_PAGE_SIZE ever be < 4k? If yes you would need to round up >> first to linux page size before shifting. > > Yes. It is needed. And md->virt_addr should be processed as follow: > > md->virt_addr & PAGE_MASK > > before fed into set_memory_*.
If you do that you also need to add the old offset into the page to the size.
I just mention it because ioremap_change_attr() did that wrong before my patch yesterday :)
-Andi
| |