Messages in this thread Patch in this message | | | Date | Fri, 15 Feb 2008 21:02:04 +0300 | From | Oleg Nesterov <> | Subject | [PATCH] do_signal_stop: use signal_group_exit() |
| |
do_signal_stop() needs signal_group_exit() but checks sig->group_exit_task. This (optimization) is correct, SIGNAL_STOP_DEQUEUED and SIGNAL_GROUP_EXIT are mutually exclusive, but looks confusing. Use signal_group_exit(), this is not fastpath, the code clarity is more important.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 25/kernel/signal.c~6_DO_SIGNAL_STOP 2008-02-15 16:59:17.000000000 +0300 +++ 25/kernel/signal.c 2008-02-15 20:34:32.000000000 +0300 @@ -1718,7 +1718,7 @@ static int do_signal_stop(int signr) struct task_struct *t; if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) || - unlikely(sig->group_exit_task)) + unlikely(signal_group_exit(sig))) return 0; /* * There is no group stop already in progress.
| |