Messages in this thread | | | Subject | Re: kernel-doc : possible fix for non-fatal perl errors when parsing some function pointers | From | Richard Kennedy <> | Date | Fri, 15 Feb 2008 17:42:24 +0000 |
| |
On Fri, 2008-02-15 at 09:21 -0800, Randy Dunlap wrote: > On Fri, 15 Feb 2008 17:13:12 +0000 Richard Kennedy wrote: > > > When running "make htmldocs" I'm seeing some non-fatal perl errors > > caused by trying to parse the callback function definitions in > > blk-core.c. > > > > > > Hi Richard, > Thanks for the patch. I was planning to look into this problem > this weekend. > > I think that changing scripts/kernel-doc to accept the current > kernel source tree usage is the right thing to do, even if the > block/blk code is a bit different. I'll test it a bit and then > push it. > > I appreciate the patch. > No problem.
I have given the patch some testing, and the output xml is the same except for the blk_end_request_callback entry.
But I wonder if it should change to this :-
> - $type =~ s/([^\(]+\(\*)$param/$1/; > + $type =~ s/([^\(]+\(\*?)\s*$param/$1/;
just in case there is some stray whitespace in there.
Richard
> --- > ~Randy
| |