Messages in this thread | | | Date | Fri, 15 Feb 2008 10:13:43 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion |
| |
Sam Ravnborg wrote: > On Tue, Jul 17, 2007 at 11:04:04PM -0400, Jeff Garzik wrote: >> This is a refresh of an on-going work-in-progress: convert the last >> remaining users of pci_find_device() to the ISA/PCI/etc. hotplug APIs >> now in standard use. After SCSI's gdth, ISDN's HiSax suite of drivers >> are just about the last place using the older API. >> >> A few rough edges remain, and I'm not sure how much of ISDN userland >> will explode (I have no ISDN hardware, nor much want any:)), but this >> should get us almost all the way there. >> >> The patches are diff'd against 2.6.25-rc1. >> >> Comments/review/testing welcome. Especially "it works" or "its dead" >> testing. > > Just ran checkpatch for the fun of it: > total: 28 errors, 86 warnings, 4896 lines checked > Most looks easy to fix.
I'll take a look... if its checkpatch stuff I caused, I'm happy to fix it.
But I'm trying to avoid cleanups for pre-existing conditions, i.e. flagged by checkpatch only because I moved existing code to a new location.
Down that path lies madness and way too much work :) I didn't sign on to clean up ISDN :)
Anyway, thanks for the multiple comments, they will be taken into account in the next update of these patches.
Jeff
| |