lkml.org 
[lkml]   [2008]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/14] [ISDN] HiSax bkm_a4t: convert to PCI hotplug API
On Tue, Jul 17, 2007 at 11:46:11PM -0400, Jeff Garzik wrote:
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
> ---
> drivers/isdn/hisax/Kconfig | 4 +-
> drivers/isdn/hisax/Makefile | 3 +-
> drivers/isdn/hisax/bkm_a4t.c | 115 ++++++++++++++++++++++++++++--------------
> drivers/isdn/hisax/config.c | 27 ++++------
> 4 files changed, 92 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig
> index 7832d8b..e7808f5 100644
> --- a/drivers/isdn/hisax/Kconfig
> +++ b/drivers/isdn/hisax/Kconfig
> @@ -286,8 +286,8 @@ config HISAX_HSTSAPHIR
> settings.
>
> config HISAX_BKM_A4T
> - bool "Telekom A4T card"
> - depends on PCI && PCI_LEGACY
> + tristate "Telekom A4T card"
> + depends on PCI
> help
> This enables HiSax support for the Telekom A4T card.
>
> diff --git a/drivers/isdn/hisax/Makefile b/drivers/isdn/hisax/Makefile
> index b0b09e9..42bfc2f 100644
> --- a/drivers/isdn/hisax/Makefile
> +++ b/drivers/isdn/hisax/Makefile
> @@ -15,7 +15,9 @@ obj-$(CONFIG_HISAX_ST5481) += hisax_st5481.o
> obj-$(CONFIG_HISAX_HFCUSB) += hfc_usb.o
> obj-$(CONFIG_HISAX_HFC4S8S) += hfc4s8s_l1.o
> obj-$(CONFIG_HISAX_FRITZ_PCIPNP) += hisax_isac.o hisax_fcpcipnp.o
> +obj-$(CONFIG_HISAX_BKM_A4T) += bkm_a4t_pci.o libhisax.o
>
> +bkm_a4t_pci-objs := bkm_a4t.o jade.o
Could we please use:
> +bkm_a4t_pci-y := bkm_a4t.o jade.o

> +static int __devinit
> setup_bkm_a4t(struct IsdnCard *card)

One single line like you do here:

> +
> +static int __devinit a4t_pci_init_one(struct pci_dev *pdev,
> + const struct pci_device_id *ent)

> +
> +static struct pci_device_id a4t_pci_table[] = {
> + { PCI_VENDOR_ID_ZORAN, PCI_DEVICE_ID_ZORAN_36120,
> + PCI_VENDOR_ID_BERKOM, PCI_DEVICE_ID_BERKOM_A4T, },
> +
> + { } /* terminate list */
> +};
const?

> +
> +static struct pci_driver a4t_pci_driver = {
> + .name = "bkm_a4t",
> + .id_table = a4t_pci_table,
> + .probe = a4t_pci_init_one,
> + .remove = hisax_pci_remove_one,
> +};
const?

> +module_param_named(protocol, a4t_protocol, int, 0444);
> +MODULE_PARM_DESC(protocol, "Values 0 (default) through 4. See ISDN_PTYPE_xxx in linux/isdnif.h");
> +
> +MODULE_DEVICE_TABLE(pci, a4t_pci_table);
> +MODULE_DESCRIPTION("ISDN HiSax BKM A4T PCI driver");
> +MODULE_LICENSE("GPL");

I thought this stuff belongs to top of file - not bottom.

Sam


\
 
 \ /
  Last update: 2008-02-15 14:37    [W:0.100 / U:7.092 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site