Messages in this thread | | | Date | Thu, 14 Feb 2008 08:57:48 +0100 | From | Andi Kleen <> | Subject | Re: [2.6 patch] x86: make dump_pagetable() static |
| |
Adrian Bunk wrote: > On Wed, Feb 13, 2008 at 02:27:47PM -0800, Harvey Harrison wrote: >> On Wed, 2008-02-13 at 23:31 +0200, Adrian Bunk wrote: >>> dump_pagetable() can now become static. >>> >>> Signed-off-by: Adrian Bunk <bunk@kernel.org> >>> >> I believe Andi Kleen wanted this kept global to make it easy to use when >> adding debugging code elsewhere. > > That's not a reason as long as his code isn't in the tree (and he anyway > has to patch the kernel for using it).
It was originally needed for the old cpa patchkit which dumped the page tables when it detected an internal inconsistency with the reference counts.
I think something like this would still make sense in a few cases, although there are no reference counts to check anymore currently.
-Andi
| |