Messages in this thread | | | Date | Thu, 14 Feb 2008 15:04:04 -0500 | From | Mathieu Desnoyers <> | Subject | Re: [PATCH] samples: build fix |
| |
* Sam Ravnborg (sam@ravnborg.org) wrote: > On Thu, Feb 14, 2008 at 08:27:52AM -0500, Mathieu Desnoyers wrote: > > * Roland McGrath (roland@redhat.com) wrote: > > > > > > The samples/ subdirectory contains only modules. > > > But the only make run done there is in commands for vmlinux. > > > I can't see why this was ever done in this nonstandard fashion. > > > As things stand, the modules don't get built by 'make modules'. > > > > > > I didn't make the addition of the directory use core-$(CONFIG_SAMPLES) > > > because there is no other conditional like that in the top-level Makefile > > > and samples/Makefile already uses obj-$(CONFIG_SAMPLES) as if it expects > > > always to be included. > > > > > > > Sam, is this ok with the samples intent ? I think as long as we do not > > include them with the kernel image and have a "make samples" to build > > them, it's ok. Having them built upon make modules seems like a good > > idea to me. > > The samples code are supposed to be what the name says 'samples'. > This is not code that are supposed to be part of the built-in kernel. > This is not modules that are supposed to be installes when > installing modules. > > Adding it to core-y as Roland does in the patch below is plain > wrong as it enabled both points above. > The fact that the present code in samples/ does not do this is > in this respect irellevant. > > Do we have problems when to build the sampls - then lets > address this issue but not by trying to upgrade the samples > to first class citizen in the kernel - they are not that > and should not be handled like that. >
Then is there some other way to have the samples built upon "make modules" that would not install them with other modules ?
Mathieu
> Sam
-- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
| |