lkml.org 
[lkml]   [2008]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] tc1100-wmi - Fail gracefully if ACPI is disabled
Date
never mind -- linus fixed this in a more elegant way.

-len

On Thursday 14 February 2008 01:11, Len Brown wrote:
> applied.
>
> thanks,
> -len
>
> On Monday 11 February 2008 14:55, Carlos Corbacho wrote:
> > tc1100-wmi - Fail gracefully if ACPI is disabled
> >
> > From: Carlos Corbacho <carlos@strangeworlds.co.uk>
> >
> > WMI drivers, like their ACPI counterparts, should also check if ACPI is
> > disabled or not, and bail out if so, otherwise we cause a crash.
> >
> > Spotted by Ingo Molnar.
> >
> > Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
> > CC: Ingo Molnar <mingo@elte.hu>
> > CC: Linus Torvalds <torvalds@linux-foundation.org>
> > CC: Andrew Morton <akpm@linux-foundation.org>
> > CC: Len Brown <lenb@kernel.org>
> > ---
> >
> > drivers/misc/tc1100-wmi.c | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> >
> > diff --git a/drivers/misc/tc1100-wmi.c b/drivers/misc/tc1100-wmi.c
> > index f25e4c9..cb8f79f 100644
> > --- a/drivers/misc/tc1100-wmi.c
> > +++ b/drivers/misc/tc1100-wmi.c
> > @@ -263,6 +263,9 @@ static int __init tc1100_init(void)
> > {
> > int result = 0;
> >
> > + if (acpi_disabled)
> > + return -ENODEV;
> > +
> > if (!wmi_has_guid(GUID))
> > return -ENODEV;
> >
> >
>


\
 
 \ /
  Last update: 2008-02-14 07:21    [W:0.049 / U:1.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site