lkml.org 
[lkml]   [2008]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHSET] printk: implement printk_header() and merging printk, take #3
Tejun Heo wrote:
>..
> * For timeouts, result TF isn't available and thus res printout is
> misleading. res shouldn't be printed after timeouts. This would
> require allocating yest another temp buf and separating out res printing
> into separate snprintf.
..

And snprintf() is buggy, by the way. It does not always seem to return
the correct character fill counts. I've given up trying to use it here
for anything in kernelspace that *must* work.

Someday I'll go back and try to figure out where it's screwing up.
I think it is doing so in the cases where it runs out of space in the buffer.

-ml


\
 
 \ /
  Last update: 2008-02-14 17:33    [from the cache]
©2003-2011 Jasper Spaans