lkml.org 
[lkml]   [2008]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kprobes: remove sparse warnings from x86
Harvey Harrison :
> arch/x86/kernel/kprobes.c:584:16: warning: symbol 'kretprobe_trampoline_holder' was not declared. Should it be static?
> arch/x86/kernel/kprobes.c:676:6: warning: symbol 'trampoline_handler' was not declared. Should it be static?
>
> Make them static and add the __used attribute, approach taken from the
> arm kprobes implementation.
>
> kretprobe_trampoline_holder uses inline assemly to define the global
> symbol kretprobe_trampoline, but nothing ever calls the holder explicitly.
>
> trampoline handler is only called from inline assembly in the same file,
> mark it used and static.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

It looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@redhat.com>

Thank you,

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com



\
 
 \ /
  Last update: 2008-02-14 16:11    [W:0.081 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site