Messages in this thread |  | | Date | Thu, 14 Feb 2008 12:02:06 +0000 | | From | Alan Cox <> | | Subject | Re: [PATCH 11/11] ata: fix sparse warnings in pata_legacy.c |
| |
On Wed, 13 Feb 2008 21:14:32 -0800 Harvey Harrison <harvey.harrison@gmail.com> wrote:
> Let's use ld for legacy_data instead of shadowing these static > int variables.
NAK - I purposefully used names that indicate what device the private data is being used for in order to make it clear. Changing qdi and winbond to ld_qdi and ld_winbond would avoid that and fix the shadowing of the static value.
Alan
|  |