Messages in this thread Patch in this message | | | Subject | [PATCH 05/11] ata: replace macro with static inline in libata.h | From | Harvey Harrison <> | Date | Wed, 13 Feb 2008 21:14:18 -0800 |
| |
Avoid a metric ton of sparse warnings like: drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one drivers/ata/pata_ali.c:176:14: originally declared here
Due to nesting min_t macro inside max_t macro which both use a __x identifier internally.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- include/linux/libata.h | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/include/linux/libata.h b/include/linux/libata.h index bc5a8d0..2845983 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -764,7 +764,11 @@ struct ata_timing { unsigned short udma; /* t2CYCTYP/2 */ }; -#define FIT(v, vmin, vmax) max_t(short, min_t(short, v, vmax), vmin) +static inline short FIT(short v, short vmin, short vmax) +{ + short tmp = min_t(short, v, vmax); + return max_t(short, tmp, vmin); +} extern const unsigned long sata_deb_timing_normal[]; extern const unsigned long sata_deb_timing_hotplug[]; -- 1.5.4.1.1278.gc75be
| |