lkml.org 
[lkml]   [2008]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [Patch 2/2] powerpc: i2c-isa: add access check to legacy ioports
    when probing i2c-pca-isa writes to legacy ioports, which crashes the kernel
    if there is no device at that port.
    This patch adds a check_legacy_ioport call, so probe failes gracefully
    and thus prevents the oops.

    Signed-off-by: Christian Krafft <krafft@de.ibm.com>

    Index: linux.git/drivers/i2c/busses/i2c-pca-isa.c
    ===================================================================
    --- linux.git.orig/drivers/i2c/busses/i2c-pca-isa.c
    +++ linux.git/drivers/i2c/busses/i2c-pca-isa.c
    @@ -125,6 +125,13 @@ static int __devinit pca_isa_probe(struc

    dev_info(dev, "i/o base %#08lx. irq %d\n", base, irq);

    +#ifdef CONFIG_PPC_MERGE
    + if (check_legacy_ioport(base)) {
    + dev_err(dev, "I/O address %#08lx is not available\n", base);
    + goto out;
    + }
    +#endif
    +
    if (!request_region(base, IO_SIZE, "i2c-pca-isa")) {
    dev_err(dev, "I/O address %#08lx is in use\n", base);
    goto out;

    --
    Mit freundlichen Gruessen,
    kind regards,

    Christian Krafft
    IBM Systems & Technology Group,
    Linux Kernel Development
    IT Specialist


    Vorsitzender des Aufsichtsrats: Martin Jetter
    Geschaeftsfuehrung: Herbert Kircher
    Sitz der Gesellschaft: Boeblingen
    Registriergericht: Amtsgericht Stuttgart, HRB 243294
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2008-02-13 18:41    [W:0.021 / U:31.796 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site