lkml.org 
[lkml]   [2008]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure
    ata_host_detach() detaches an attached port and shouldn't be called on
    a port which hasn't been attached yet. pata_legacy incorrectly calls
    ata_host_detach() on unattached port after initialization failure
    causing oops. Fix it.

    Signed-off-by: Tejun Heo <htejun@gmail.com>
    Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Arjan van de Ven <arjan@infradead.org>
    ---
    drivers/ata/pata_legacy.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c
    index 333dc15..7383f19 100644
    --- a/drivers/ata/pata_legacy.c
    +++ b/drivers/ata/pata_legacy.c
    @@ -1278,8 +1278,6 @@ static __init int legacy_init_one(struct legacy_probe *probe)
    }
    }
    fail:
    - if (host)
    - ata_host_detach(host);
    platform_device_unregister(pdev);
    return ret;
    }

    \
     
     \ /
      Last update: 2008-02-13 10:23    [W:0.026 / U:0.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site