lkml.org 
[lkml]   [2008]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCHSET] printk: implement printk_header() and merging printk, take #3
Date
Hello, all.

This is the third take of implement-printk_header-and-mprintk
patchset.

Changes from the last take[L] are...

* Now header is printed on every line of a multiline message. If the
header ends with ':' followed by spaces. The colon is replaced with
space from the second line.

* s/mprintk/mprintk_flush/ and s/mprintk_add/mprintk/ as suggested.

* mprintk_init_alloc() and mprintk_free() added to ease malloc'd
buffer handling. No need to specify buffer size. Sizing is left to
mprintk.

This patchset aims to make printing multiline messages and assembling
message piece-by-piece easier.

In a nutshell, printk_header() lets you do the following atomically
(against other messages).

code:
printk(KERN_INFO "ata1.00: ", "line0\nline1\nline2\n");

output:
<6>ata1.00: line0
<6>ata1.00 line1
<6>ata1.00 line2

And mprintk the following.

code:
DEFINE_MPRINTK(mp, 2 * 80);

mprintk_set_header(&mp, KERN_INFO "ata%u.%2u: ", 1, 0);
mprintk_push(&mp, "ATA %d", 7);
mprintk_push(&mp, ", %u sectors\n", 1024);
mprintk(&mp, "everything seems dandy\n");

output:
<6>ata1.00: ATA 7, 1024 sectors
<6>ata1.00 everything seems dandy

For more info, please read Documentation/printk.txt which is created
by the fourth patch.

This patchset is on top of

linux-2.6#master (96b5a46e2a72dc1829370c87053e0cd558d58bc0)
+ printk-fix-possible-printk-buffer-overrun [1]
+ printk-implement-printk_buf-overflow-warning [2]

and contains the following patches.

0001-printk-keep-log-level-on-multiline-messages.patch
0002-printk-implement-v-printk_header.patch
0003-printk-implement-merging-printk.patch
0004-printk-add-Documentation-printk.txt.patch
0005-libata-make-libata-use-printk_header-and-mprintk.patch

Documentation/00-INDEX | 2
Documentation/printk.txt | 724 ++++++++++++++++++++++++++++++++++++++++++++
drivers/ata/libata-core.c | 204 +++++++-----
drivers/ata/libata-eh.c | 182 +++++------
drivers/ata/libata-pmp.c | 5
drivers/ata/libata-scsi.c | 6
drivers/ata/sata_inic162x.c | 2
drivers/ata/sata_nv.c | 4
include/linux/kernel.h | 85 +++++
include/linux/libata.h | 35 +-
kernel/printk.c | 435 ++++++++++++++++++++++++--
11 files changed, 1453 insertions(+), 231 deletions(-)
If this gets acked, I think it's best to push it through libata-dev as
libata is the first user.

Thanks.

--
tejun

[L] http://thread.gmane.org/gmane.linux.ide/27317
[1] http://article.gmane.org/gmane.linux.kernel/639018
[2] http://article.gmane.org/gmane.linux.kernel/639029


\
 
 \ /
  Last update: 2008-02-13 10:13    [from the cache]
©2003-2011 Jasper Spaans