lkml.org 
[lkml]   [2008]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] NBD: make nbd default to deadline I/O scheduler
On Sat, 09 Feb 2008 08:30:40 -0500
Paul Clements <paul.clements@steeleye.com> wrote:

> + old_e = disk->queue->elevator;
> + if (elevator_init(disk->queue, "deadline") == 0 ||
> + elevator_init(disk->queue, "noop") == 0) {
> + elevator_exit(old_e);
> + }
> }

afacit elevator_init() will not trigger a request_module(). And you really
do want to trigger the request_module() here. Perhaps the block layer
should provide a means of doing so?



\
 
 \ /
  Last update: 2008-02-13 00:19    [from the cache]
©2003-2011 Jasper Spaans