lkml.org 
[lkml]   [2008]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [7/8] Implement true end_pfn_mapped for 32bit
    On Tue, 12 Feb 2008, Andi Kleen wrote:
    > > > @@ -36,7 +36,7 @@
    > > > #define max_pfn_mapped end_pfn_map
    > > > #else
    > > > #include <asm/page_32.h>
    > > > -#define max_pfn_mapped max_low_pfn
    > > > +#define max_pfn_mapped end_pfn_map
    > >
    > > We can nuke either max_pfn_mapped or end_pfn_map completely. I don't
    > > care about which one, but keeping both makes no sense at all.
    >
    > I didn't want to bundle such a clean up into the bug fix
    > because my experience is that you usually reject that categorically.

    True, but I apply two separate patches.

    > I can send the removal of max_pfn_mapped as a follow up patch
    > if you apply this one.

    Too late. It was so obvious that it screamed to be fixed. I applied
    the inital patch already and cleaned it up myself. :)

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2008-02-12 21:29    [W:0.020 / U:89.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site